pingcap / pingcap/tiflash

[potenial bug] TiFlash's join output schema is different than TiDB's.

Open
#4,941 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

affects-6.1 affects-6.2 affects-6.3 affects-6.4 component/compute may-affects-4.0 may-affects-5.0 may-affects-5.1 may-affects-5.2 may-affects-5.3 may-affects-5.4 may-affects-6.0 severity/moderate type/bug
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Tiflash join's output schema is strictly equal to input schema's union.

so planner must reset mppjoin schema in physicalOptimize.

it may broke the optimization or assumption done by logicalOptimize.

for example:
https://github.com/pingcap/tidb/issues/34765

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating physicalOptimize and logicalOptimize, then trace how the mppjoin schema is produced and consumed for TiFlash joins. Compare the output-schema behavior with TiDB using issue #34765 as context; the work is done when the planner's schema handling matches the expected TiDB behavior without breaking logical-optimization assumptions.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.