pingcap / pingcap/tiflash

multi-thread safe getGCSafePointWithRetry

Open
#4,928 1 comment 0 reactions 1 assignee View on GitHub

@breezewish is already working on this.

Since May 19, 2022.

component/storage type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

Currently there is a race condition in getGCSafePointWithRetry which makes it buggy. The getGCSafePointWithRetry are now called in a least 3 kind of threads:

  • Read thread
  • Background thread
  • Manual compaction thread

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.