pingcap / pingcap/tiflash

BlockInputStream useless code removal

Open
#4,908 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

There are many BlockInputStream class from upstream clickhouse that are not used.
For code readability and building speed, It's better to drop all of them.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the BlockInputStream classes in the TiFlash codebase and checking their usage against the upstream ClickHouse references mentioned in the issue. Done means unused classes are removed while the project still builds successfully and no remaining code depends on them.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.