pingcap / pingcap/tiflash

Interpreter useless code removal

Open
#4,860 0 comments 0 reactions 1 assignee View on GitHub

@ywqzzy is already working on this.

Since May 11, 2022.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

There are many interpreter class from upstream clickhouse that are not used.
For code readability, It's better to drop all of them.

There are several types of interpreter class, they are listed as follow:

  1. SelectQuery
  2. AlterQuery
  3. DropQuery
  4. CreateQuery
  5. RenameQuery
  6. ManageQuery
  7. ShowTablesQuery
  8. OptimizeQuery #4589
  9. TruncateQuery #4587
  10. TableProperties #4586
  11. CheckQuery #4569 #4568
  12. KillQUery #4567 #4564
  13. SystemQuery #4590
  14. UseQuery
  15. SetQuery
  16. DeleteQuery #4589
  17. DescribeQuery
  18. ExistQuery
  19. InsertQuery
  20. ShowProcesslist

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.