pingcap / pingcap/tiflash

different prefix

Open
#4,847 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/compute severity/moderate type/bug
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Bug Report

  1. If you want to realize the function of online modification of configuration file parameters, the unification of parameter names is easier for users to understand
  2. When the user queries the parameter value through sql, or our support staff queries the parameter, it may be confusing, and it is difficult to confirm whether the two parameters have the same meaning
  3. I only tested this one parameter modification, other parameters want to check by themselves
    Good luck!!!
    Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
  1. mysql> show config where name like '%pool-size%' and type = 'tiflash';
    +---------+-----------------------------------------------------------+--------------------------------------------------------+-------+
    | Type | Instance | Name | Value |
    +---------+-----------------------------------------------------------+--------------------------------------------------------+-------+
    | tiflash | basic-tiflash-0.basic-tiflash-peer.tidb-cluster1.svc:3930 | **raftstore-proxy.**raftstore.apply-low-priority-pool-size | 1 |
    | tiflash | basic-tiflash-0.basic-tiflash-peer.tidb-cluster1.svc:3930 | raftstore-proxy.raftstore.apply-pool-size | 4 |
    | tiflash | basic-tiflash-0.basic-tiflash-peer.tidb-cluster1.svc:3930 | raftstore-proxy.raftstore.snap-handle-pool-size | 2 |
    | tiflash | basic-tiflash-0.basic-tiflash-peer.tidb-cluster1.svc:3930 | raftstore-proxy.raftstore.store-low-priority-pool-size | 0 |
    | tiflash | basic-tiflash-0.basic-tiflash-peer.tidb-cluster1.svc:3930 | raftstore-proxy.raftstore.store-pool-size | 4 |
    | tiflash | basic-tiflash-0.basic-tiflash-peer.tidb-cluster1.svc:3930 | raftstore-proxy.resolved-ts.scan-lock-pool-size | 2 |
    | tiflash | basic-tiflash-0.basic-tiflash-peer.tidb-cluster1.svc:3930 | raftstore-proxy.server.status-thread-pool-size | 1 |
    | tiflash | basic-tiflash-0.basic-tiflash-peer.tidb-cluster1.svc:3930 | raftstore-proxy.storage.scheduler-worker-pool-size | 4 |
    +---------+-----------------------------------------------------------+--------------------------------------------------------+-------+
    8 rows in set (0.04 sec)
  2. [root@172 tiflash-9000]# cat conf/tiflash-learner.toml | grep raftstore -A 2
    [raftstore]
    apply-pool-size = 4
    store-pool-size = 4
    [root@172 tiflash-9000]# pwd
    /home/tidb/qh/deploy/tiflash-9000
    [root@172 tiflash-9000]#
2. What did you expect to see? (Required)

same name

3. What did you see instead (Required)

show config:raftstore-proxy
cat toml:raftstore

4. What is your TiFlash version? (Required)

Release Version: v5.4.0
Edition: Community
Git Commit Hash: 55f3b24c1c9f506bd652ef1d162283541e428872
Git Branch: heads/refs/tags/v5.4.0
UTC Build Time: 2022-01-25 08:39:26
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the show config query and conf/tiflash-learner.toml, comparing the raftstore-proxy names returned by SQL with the raftstore names in the TOML configuration. Check the other pool-size parameters mentioned in the output as well. Done means the SQL-visible names and configuration names use the same prefix consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.