pingcap / pingcap/tiflash

tiflash may stuck by logger when log rorating.

Open
#4,628 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 affects-6.0 affects-6.1 component/compute severity/moderate type/bug
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

When poco logger rotating, all the log of tiflash will be hang.

middle_img_v2_b274e0bf-2a95-4cb6-8426-ad2a6969aa3g

Bug Report

log rorate blocking all log beviours from other threads including GRPC

1. Minimal reproduce step (Required)

1.let log rorating occur. such as:use trace log level

2. What did you expect to see? (Required)

there will be logs as soon as log rorate occur.

3. What did you see instead (Required)

there will be no log for a few seconds when log rorate occur.

4. What is your TiFlash version? (Required)

All

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with trace logging enabled and observe log rotation while other threads, including GRPC, are active. Trace the Poco logger rotation path and identify why logging blocks for several seconds. Done means logs continue to appear promptly during rotation, with coverage for the reported behavior if the project provides relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
observability
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.