Remove useless dataType related code.
Open
Nobody has claimed this yet.
good first issue
help wanted
type/enhancement
- Dominant language
- C++
- Stars
- 1k
- Forks
- 423
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 24
Description
Enhancement
In TiFlash some of the dataTypes used in Clickhouse is useless.
In order to make the build process of TiFlash faster, and make the code cleaner, we need to remove some DataTypes.
The following DataType is useless till now(Not fully sure of it)
- "DataTypeDate"/"DateTypeDateTime". We use "DataTypeMyDate"/"DataTypeMyDatetime" for MySQL/TiDB-compatibility,
- "DataTypeTuple"/"DataTypeArray"/"DataTypeSet" We don't use these data type
- "DataTypeFixedString" MySQL doesn't support it.
Also the issue is related to #2019
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the TiFlash implementations and references for DataTypeDate, DateTypeDateTime, DataTypeTuple, DataTypeArray, DataTypeSet, and DataTypeFixedString. Check the related issue #2019 and verify each type is unused before removing it; done means the build remains successful and no references to the removed types remain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100