Limit the maximum line length of TiFlash log
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 423
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 24
Description
Enhancement
A user executes SQL with more than ten thousand of in (...), under debug logging level, we print out the protobuf request debug string and rough set filter string. Those debug strings can reach 16 MB for some lines, making it hard to check logging files. And it also consumes some CPU and disk bandwidth and makes execution slow.
The maximum length of logging is limited to a reasonable length.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the TiFlash debug logging that prints the protobuf request debug string and rough set filter string. Trace how those strings reach the log output, then verify that long values are bounded and that logging no longer produces excessively large lines or unnecessary work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend, observability
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100