Handle maxAllowedPacket in string functions in tiflash
Open
Nobody has claimed this yet.
type/enhancement
- Dominant language
- C++
- Stars
- 1k
- Forks
- 423
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 24
Description
Enhancement
For now, our implementation of string functions in tiflash doesn't handle maxAllowedPacket at all. But almost all string functions in tidb handle it explicitly(check concat)
We need to handle it in a common function.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced TiDB concat implementation in builtin_string.go, then locate the corresponding string-function code in TiFlash. Determine how maxAllowedPacket should be handled through a shared function; done means string functions consistently enforce that limit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100