tiflash supports default beheavor for invalid decimal type
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 423
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 24
Description
Enhancement
ONCALL-3800 decimal(23, -1) is invalid;
https://github.com/pingcap/tics/issues/3373 Decimal(48,31)is out of bound
https://github.com/pingcap/tics/issues/3091 Wrong precision:128
propose:
once thiflash received invalid decimals, we should regard them as the max value. for example deciaml(xx,-1), change -1 to min(max_precision - xx, max_scale).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, test, or entry point is named. Start by tracing TiFlash's handling of invalid decimal types and compare the linked cases for negative scale, out-of-bound precision, and precision 128. Done means invalid decimals are normalized to the proposed maximum valid value without regressing those cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100