pingcap / pingcap/tiflash

Rewrite timestamp_rough_set_filter.test into another test case

Open
#3,433 0 comments 0 reactions 1 assignee View on GitHub

@hehechen is already working on this.

Since Nov 12, 2021.

Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

I don't think that we check the result by DBGInvoke search_log_for_key('RSFilter exclude rate') in tests/delta-merge-test/query/misc/timestamp_rough_set_filter.test is a good way for testing. Can we rewrite timestamp_rough_set_filter.test into another test case by the same way as these ut?

Originally posted by @JaySon-Huang in https://github.com/pingcap/tics/issues/3419#issuecomment-966801665

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.