pingcap / pingcap/tiflash

`IProfilingBlockInputStream` sometimes can't collect stat for `readPrefix`/`readSuffix`.

Open
#3,384 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/code-quality-improvement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

https://docs.google.com/document/d/1V5OEu7skfRIkgjwsfO6gy877Mpx0Xx2oX_N0ZHtKZUY/edit?n=Input_Stream_Statistics#bookmark=id.g0kfwpq89nwb

IProfilingBlockInputStream allows subclass overriding readPrefix/readSuffix, but it makes IProfilingBlockInputStream not able to collect runtime information for these two functions.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with IProfilingBlockInputStream and its readPrefix/readSuffix entry points, then read the linked Input Stream Statistics document to understand the intended runtime information. Determine how subclass overrides should be accounted for and verify that statistics are collected for both methods.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.