pingcap / pingcap/tiflash

Deprecated Copy Across the Project

Open
#3,280 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

[398/992] Building CXX object dbms/CMakeFiles/dbms.dir/src/Interpreters/AsynchronousMetrics.cpp.o
In file included from ../dbms/src/Interpreters/AsynchronousMetrics.cpp:9:
In file included from ../dbms/src/Storages/DeltaMerge/DeltaMergeStore.h:9:
In file included from ../dbms/src/Storages/DeltaMerge/RowKeyRange.h:7:
In file included from ../dbms/src/Storages/DeltaMerge/DeltaMergeHelpers.h:15:
../dbms/src/Storages/Transaction/TiDB.h:317:5: warning: definition of implicit copy assignment operator for 'TableInfo' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
    TableInfo(const TableInfo &) = default;
    ^
../dbms/src/Storages/StorageDeltaMerge.h:94:87: note: in implicit copy assignment operator for 'TiDB::TableInfo' first required here
    void setTableInfo(const TiDB::TableInfo & table_info_) override { tidb_table_info = table_info_; }
                                                                                      ^
1 warning generated.
[404/992] Building CXX object dbms/CMakeFiles/dbms.dir/src/Interpreters/InterpreterManageQuery.cpp.o
In file included from ../dbms/src/Interpreters/InterpreterManageQuery.cpp:7:
In file included from ../dbms/src/Storages/StorageDeltaMerge.h:9:
../dbms/src/Storages/Transaction/TiDB.h:317:5: warning: definition of implicit copy assignment operator for 'TableInfo' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
    TableInfo(const TableInfo &) = default;
    ^
../dbms/src/Storages/StorageDeltaMerge.h:94:87: note: in implicit copy assignment operator for 'TiDB::TableInfo' first required here
    void setTableInfo(const TiDB::TableInfo & table_info_) override { tidb_table_info = table_info_; }
                                                                                      ^
1 warning generated.
[428/992] Building CXX object dbms/CMakeFiles/dbms.dir/src/Debug/dbgFuncMockRaftSnapshot.cpp.o
../dbms/src/Debug/dbgFuncMockRaftSnapshot.cpp:235:9: warning: definition of implicit copy assignment operator for 'Data' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
        Data(const Data &) = delete;
        ^
../dbms/src/Debug/dbgFuncMockRaftSnapshot.cpp:383:97: note: in implicit copy assignment operator for 'DB::MockSSTReader::Data' first required here
        MockSSTReader::getMockSSTData()[MockSSTReader::Key{store_key, ColumnFamilyType::Write}] = std::move(write_kv_list);
                                                                                                ^
1 warning generated.
[430/992] Building CXX object dbms/CMakeFiles/dbms.dir/src/Interpreters/Quota.cpp.o
In file included from ../dbms/src/Interpreters/Quota.cpp:8:
../dbms/src/Interpreters/Quota.h:188:5: warning: definition of implicit copy assignment operator for 'QuotaForIntervals' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
    QuotaForIntervals(const QuotaForIntervals & other) = default;
    ^
../dbms/src/Interpreters/Quota.cpp:275:13: note: in implicit copy assignment operator for 'DB::QuotaForIntervals' first required here
        max = new_max;
            ^
1 warning generated.
[474/992] Building CXX object dbms/CMakeFiles/dbms.dir/src/Debug/dbgFuncCoprocessor.cpp.o
In file included from ../dbms/src/Debug/dbgFuncCoprocessor.cpp:5:
In file included from ../dbms/src/DataStreams/TiRemoteBlockInputStream.h:4:
In file included from ../dbms/src/Flash/Coprocessor/CHBlockChunkCodec.h:3:
In file included from ../dbms/src/Flash/Coprocessor/ChunkCodec.h:4:
In file included from ../dbms/src/Storages/Transaction/TypeMapping.h:5:
../dbms/src/Storages/Transaction/TiDB.h:317:5: warning: definition of implicit copy assignment operator for 'TableInfo' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
    TableInfo(const TableInfo &) = default;
    ^
../dbms/src/Debug/dbgFuncCoprocessor.cpp:2273:20: note: in implicit copy assignment operator for 'TiDB::TableInfo' first required here
        table_info = schema_fetcher(database_name, table_name);
                   ^
1 warning generated.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the C++ build warnings and inspect the declarations and assignments shown in dbms/src/Storages/Transaction/TiDB.h, StorageDeltaMerge.h, Quota.h, Quota.cpp, dbgFuncMockRaftSnapshot.cpp, and dbgFuncCoprocessor.cpp. Determine the project-wide scope of the deprecated-copy warnings; done means the affected build no longer reports these warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.