Let TiFlash log asynchronously
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 423
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 24
Description
Currently, TiFlash log synchronously using Poco Framework, log function such as LOG_INFO will wait until the log message flush to the disk.
It may become bottleneck and if there is any error scenario crazy logging, will lead to further degradation of the system.
I think we should let TiFlash log asynchronously by using Poco::AsyncChannel
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating TiFlash's Poco-based logging setup and the LOG_INFO entry points, then read Poco::AsyncChannel documentation and the existing logging flow. Done means log calls no longer wait for messages to flush to disk while preserving the intended log output and handling the stated error-heavy logging scenario.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- observability, performance
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100