pingcap / pingcap/tiflash

Exchange partition sender does not respect `records_per_chunk`

Open
#2,810 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

In StreamingDAGResponseWriter, broadcast sender will split blocks by records_per_chunk but partition sender does not split. It may result in sending a very large chunk in one DAG response. See StreamingDAGResponseWriter::getEncodePartitionTask.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in StreamingDAGResponseWriter::getEncodePartitionTask and compare the partition sender with the broadcast sender's records_per_chunk handling. Confirm how partition blocks are assembled and define done as partition responses being split according to records_per_chunk rather than sending one potentially very large chunk.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
distributed-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.