pingcap / pingcap/tiflash

Consider `corrosion` for better automatical integration

Open
#2,536 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

If we finally manage to upgrade the cmake version in the CI, we can consider using the following cmake module:
https://github.com/AndrewGaspar/corrosion
If so, no manual interfere is needed anymore.

cc @fuzhe1989 @solotzg

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking the CI's current CMake version and how the existing manual integration is handled. Review the corrosion CMake module linked in the issue; the work is done when its suitability is established after the CMake upgrade and manual integration is no longer needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.