pingcap / pingcap/tiflash

make MPP Cancel take effects for mpp task that is still in compile stage

Open
#2,439 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Currently, MPP Cancel only can cancel mpp tasks that already in running state, for those not in runnging state(for example, still in compiling stage), they are not cancelled until begin running. Since compiling may take a long time during to wait_index, it's better to make MPP Cancel take effects for mpp task that is still in compile stage.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace MPP Cancel handling and the compile-stage path around wait_index, focusing on why cancellation is honored only after a task enters running state. Done means an MPP task still compiling can be cancelled promptly instead of waiting until it begins running; verify the behavior with the relevant existing test coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.