pingcap / pingcap/tiflash

LTO support

Open
#2,168 0 comments 0 reactions 1 assignee View on GitHub

@SchrodingerZhu is already working on this.

Since Jun 16, 2021.

Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

If #2164 was merged, we will have gcc-10 support. GCC 10 will have a good capability to do excellent Link Time Optimization. Besides, we vendor most of our dependencies, which means there may be more room to do the optimization.

Issues found during my local exps:

  1. some warning flags suppression does not take effect in LTO, (maybe-uninitialized), we may disable -Werror or add -Wno-maybe-uninitialized in LTO mode
  2. ODR violation detected due to usage of anon namespace in header file: dbms/src/DataStreams/UnionBlockInputStream.h

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.