pingcap / pingcap/tiflash

The format of tiflash version is inconsistent with other components in the system table.

Open
#2,034 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/compute severity/moderate type/bug
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

In theinformation_schema.cluster_info table, the format of tiflash version is inconsistent with other components.

others: 5.0.1
tiflash: v5.0.1

mysql> select * from information_schema.cluster_info;
+---------+-----------------+-----------------+---------+------------------------------------------+---------------------------+-----------------+-----------+
| TYPE    | INSTANCE        | STATUS_ADDRESS  | VERSION | GIT_HASH                                 | START_TIME                | UPTIME          | SERVER_ID |
+---------+-----------------+-----------------+---------+------------------------------------------+---------------------------+-----------------+-----------+
| tidb    | 127.0.0.1:4000  | 127.0.0.1:10080 | 5.0.1   | 1145e347d3469d8e89f88dce86f6926ca44b3cd8 | 2021-05-31T17:44:13+08:00 | 3h21m31.67595s  |         0 |
| pd      | 127.0.0.1:2379  | 127.0.0.1:2379  | 5.0.1   | ea1449c7c693d94661b3c60d35b8679ebfb3da34 | 2021-05-31T17:44:04+08:00 | 3h21m40.675956s |         0 |
| tikv    | 127.0.0.1:20160 | 127.0.0.1:20180 | 5.0.1   | e26389a278116b2f61addfa9f15ca25ecf38bc80 | 2021-05-31T17:44:09+08:00 | 3h21m35.675958s |         0 |
| tiflash | 127.0.0.1:3930  | 127.0.0.1:20292 | v5.0.1  | 1821cf655bc90e1fab6e6154cfe994c19c75d377 | 2021-05-31T17:44:21+08:00 | 3h21m23.67596s  |         0 |
+---------+-----------------+-----------------+---------+------------------------------------------+---------------------------+-----------------+-----------+
4 rows in set (0.00 sec)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the information_schema.cluster_info table obtains and formats the TiFlash VERSION value, then compare it with the TiDB, PD, and TiKV entries shown in the report. Done means TiFlash reports 5.0.1 rather than v5.0.1, with coverage for the displayed query if the relevant test location is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.