pingcap / pingcap/tiflash

Clean up redundant code for TiFlash

Open
#2,019 8 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted type/code-quality-improvement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

TiFlash fork from Clickhouse around late 2018. There are lots of useless codes for TiFlash.

Something not sure:

  • Remove redundant data types so that we don't need to instantiate some template class for these data types, which may greatly reduce our compile time
    • "DataTypeDate"/"DateTypeDateTime"
      We use "DataTypeMyDate"/"DataTypeMyDatetime" for MySQL/TiDB-compatibility, these original data types ported from Clickhouse are useless for TiFlash
    • "DataTypeTuple"/"DataTypeArray"/"DataTypeSet"
      We don't use these data type

Possible it is good for speeding up our CI building step #1390.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the remaining unchecked items: the XML dependency, issue #3486, and redundant data types such as DataTypeDate, DataTypeDateTime, DataTypeTuple, DataTypeArray, and DataTypeSet. Confirm which are still used before removing them, and consider the impact on CI build time; done means the redundant code or dependencies are removed without breaking the build.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, performance
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.