pingcap / pingcap/tiflash

Fsync directory after created and fix other not atomic operations that may make the underlying data broken

Open
#1,930 1 comment 0 reactions 1 assignee View on GitHub

@lidezhu is already working on this.

Since May 19, 2021.

affects-6.0 component/storage severity/moderate type/bug
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Currently we only fsync normal file after finishing write to it. But we also need to fsync directory after they are created, otherwise if the system crash before the directory's data flushing to disk, the storage data represented by the directory may be in a broken state.
And we also need to find and fix other non-atomic operation that may make the underlying data broken.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.