pingcap / pingcap/tiflash

A table from TiDB without a TiFlash replica still need to create a *.sql file in TiFlash

Open
#1,817 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

This PR has solved a problem that a table without a TiFlash replica still needs to create a DeltaMergeStore object and result in creating a lot of files.

However, we still need to create a *.sql file for table schema in TiFlash. If there are tens of thousands of tables without a TiFlash replica, it is still an unnecessary and expensive cost.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review PR #1751 first, then locate the TiFlash path that creates the table-schema *.sql file. Reproduce the case with a TiDB table that has no TiFlash replica and verify that no unnecessary schema file is created, while tables with replicas retain the required file.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.