Disable debugging port for TiFlash in production environment
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 423
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 24
Description
The TCP/HTTP port (9000,8123 by default) for TiFlash are inherited from clickhouse.
TiFlash mainly uses these two ports for debugging purposes. The TCP/HTTP ports of TiFlash remain open in the production environment.
It can be a security problem cause we don't have access control for connections to the TCP port.
@marsishandsome tried to close the TCP port on this PR #1331, but close the PR since we don't have complete tests on TiUP.
Reference
- The port we list in the document: Network requirements
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #1331 and the referenced Network requirements documentation to understand the intended production port behavior. Then inspect the TiUP test coverage mentioned in the issue; done means the TCP/HTTP ports are disabled or protected in production and the relevant TiUP tests cover the change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- infrastructure, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100