pingcap / pingcap/tiflash

TiFlash should return "Region not found" instead of "TiFlash is Terminating" in the process of exiting when batch cop is enabled

Open
#1,460 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/coprocessor
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

When tiflash receive terminal signal, it should return "Region not found" when serving cop request, so tidb can retry the cop request. But when batch cop is enabled, it returns "TiFlash is Terminating" and tidb return the error to the client.
This behavior make it not applicable for tiflash to do online upgrade.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing TiFlash's termination handling for batch cop requests after a terminal signal, including where the "TiFlash is Terminating" response is produced. Reproduce the exiting-state behavior and verify that batch cop requests instead produce "Region not found" so TiDB can retry them during online upgrades.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.