Potential unaligned memory access causes bus error on ARM
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 423
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 24
Description
Bug Report
https://github.com/pingcap/tiflash/blob/943351404a3a883dcf45020cc2df3dfebf18bdd7/dbms/src/Columns/ColumnString.h#L250
https://github.com/pingcap/tiflash/blob/943351404a3a883dcf45020cc2df3dfebf18bdd7/dbms/src/Columns/ColumnArray.cpp#L214
https://github.com/pingcap/tiflash/blob/2a198f197e80a3a612f6f1229efaca61dc0bf526/dbms/src/Interpreters/Aggregator.h#L395
These raw pointer reads may dereference non-aligned addresses, which is unsafe on strict-alignment ARM systems and can cause bus errors.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the referenced locations in dbms/src/Columns/ColumnString.h, dbms/src/Columns/ColumnArray.cpp, and dbms/src/Interpreters/Aggregator.h, starting with the raw pointer reads at the cited lines. Validate the behavior on a strict-alignment ARM system; done means those reads no longer risk bus errors from non-aligned addresses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100