pingcap / pingcap/tiflash

Downgrade some unnecessary loggings

Open
#10,638 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

affects-8.5 component/storage severity/moderate type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

Downgrade from "error" to "info"

[2026/01/04 10:28:24.366 +00:00] [ERROR] [command.rs:187] ["transfer leader won't exec"] [req="cmd_type: TransferLeader transfer_leader { peer { id: 19010003 store_id: 96 role: IncomingVoter } }"] [region="id: 13472243 start_key: ? end_key: ? region_epoch { conf_ver: 145 version: 521 } peers { id: 13472244 store_id: 36 role: Learner } peers { id: 13472246 store_id: 35 role: Learner } peers { id: 13473633 store_id: 11 } peers { id: 13473631 store_id: 12 role: Learner } peers { id: 13473630 store_id: 39 } peers { id: 13473632 store_id: 94 role: DemotingVoter } peers { id: 19010003 store_id: 96 role: IncomingVoter }"] [thread_id=418]

https://github.com/pingcap/tidb-engine-ext/blob/768e3440b32dafe94d326b298e64a1165ea7ec0e/proxy_components/engine_store_ffi/src/core/forward_raft/command.rs#L187-L190


Downgrade from "warn" to "info"

when extra_suffix is '00'

[2026/01/04 09:59:25.592 +00:00] [WARN] [RowKeyRangeFromRegion.cpp:110] ["Meet rowkey which has extra suffix, keyspace=4294967295 table_id=488920  end_key=? end_key_extra_suffix=00 region_id=38012807 getQueryRanges"] [thread_id=8831]

when meet empty schema diff

[2026/01/04 10:28:18.161 +00:00] [WARN] [SchemaGetter.cpp:254] ["The schema diff is empty, schema_version=73978 key=Diff:73978"] [thread_id=8182]
[2026/01/04 08:22:27.828 +00:00] [WARN] [TiDBSchemaSyncer.cpp:164] ["Skip an empty schema diff, schema_version=45172 cur_version=45171 latest_version=45173"] [source="keyspace=4294967295"] [thread_id=7934]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the logging sites in engine_store_ffi/src/core/forward_raft/command.rs around lines 187-190, RowKeyRangeFromRegion.cpp:110, SchemaGetter.cpp:254, and TiDBSchemaSyncer.cpp:164. Verify each listed condition and change only the specified error or warning severity to info; done means these expected conditions no longer emit error or warn logs.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, rust
Domain
observability-sre
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.