pingcap / pingcap/tiflash

[next gen] Release disagg snapshot on write node in a more timely manner

Open
#10,433 2 comments 0 reactions 1 assignee View on GitHub

@JaySon-Huang is already working on this.

Since Sep 16, 2025.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

In the case of storage-computing disaggregated arch, a compute node will register a snapshot on write node when processing a request. A snapshot created on write node has a 30-minute timeout. If a compute node pulls segment delta data from write node to compute node based on the snapshot, the write node snapshot creation time will be extended by 5 minutes. If all segment delta data for a snapshot has been pulled by compute node, write node will release the snapshot; otherwise, write node will automatically release the snapshot after the timeout expires.
Under query kill or query failure, it only release the MPPTask on compute node. The disagg snapshot on write node now can only be released by timeout mechanism, which is 30 minutes now.

After https://github.com/pingcap/tiflash/pull/10410, the 30 minutes long disagg snapshot does not cause write node OOM. But it would be better if we can find a better way to release the disagg snapshot on write node in a more timely manner.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.