pingcap / pingcap/tiflash

add keyspace id in metrics

Open
#10,228 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

the metrics only contains resource group names, in next-gen, same resource group can exists in different keyspace.
So we also needs to add keyspace id in these metrics.
Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the metrics that currently expose resource group names and trace how those values are collected in next-gen. Confirm where the keyspace ID is available and identify the relevant metric tests, if present. Done means the affected metrics distinguish identical resource group names across keyspaces and existing tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.