pingcap / pingcap/tiflash

storage checkpoint should also respect storage.temp.capacity

Open
#10,109 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

https://github.com/pingcap/tiflash/pull/10035 add storage.temp.capacity to limit spilling files,
but storage checkpoint also use storage.temp.dir, which respect storage.temp.capacity for now.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked pull request #10035 and tracing how storage checkpoint uses storage.temp.dir and storage.temp.capacity. Done means storage checkpoint spilling also respects the configured storage.temp.capacity limit, with any relevant validation covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.