pingcap / pingcap/tidb

br: support snapshot backup repository layout

Open
#67,964 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

Support a repo-scoped snapshot backup layout in BR so multiple snapshot backups can share one storage prefix safely.

### Problem

Today, BR snapshot backup expects an empty `--storage` path and writes `backupmeta`, `backup.lock`, and SSTs directly into that path. In very large S3-compatible repositories, creating a brand-new prefix and immediately writing a large number of objects can trigger throttling or timeouts.

### Proposed enhancement

- Treat `--storage` as a repository root for snapshot backups.
- Reserve `_meta/` and `_data/` namespaces for metadata and large data.
- Allocate a stable backup ID per snapshot backup attempt.
- Shard snapshot SST data by store under `_data/snapshot///`.
- Add repo-level metadata and pending markers for resume, listing, delete, and cleanup flows.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.