pingcap / pingcap/tidb

BR restore point (PiTR)'s default `--pitr-concurrency` may be too small

Open
#64,872 0 comments 0 reactions 0 assignees View on GitHub
component/br type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

```
--pitr-concurrency uint32 specify the concurrency to restore log. (default 16)
```

meanwhile the benchmark all uses `--pitr-concurrency=128` 🤷 https://docs.pingcap.com/tidb/stable/br-pitr-guide/#performance-capabilities-of-pitr

in a customer (TICKET-8018) we found that the default setting of 16 is unbearably slow (2 files/second), increasing this to 128 brings it back to acceptable speed (30 files/second).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.