pingcap / pingcap/tidb

Refact grafana json files for classis and next gen

Open
#62,286 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement
In https://github.com/pingcap/tidb/pull/61688, we added next gen specific grafana json files to distinguish metrics with keyspace_name labels and not. However, it shares many common code with classic ones, and introduces double-work for modifying exsiting metrics. Even worse, deveplopers may forget to update the other one. It would be helpful to use jsonnet script to refact them, and reuse code as much as possible.
Before this feature is completed, we may need to review all metrics related changes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.