pingcap / pingcap/tidb

`NULL_COL_IDS` is not filled when encode row to bytes

Open
#61,709 2 comments 0 reactions 0 assignees View on GitHub
may-affects-7.1 may-affects-7.5 may-affects-8.1 may-affects-8.5 severity/major type/bug
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report

If `canSkip` return `true` here, colID will not append to `EncodeRowBuffer.ColIDs`.

https://github.com/pingcap/tidb/blob/9f671d6299f903aa7672ac8c654d76151a497695/pkg/table/tables/tables.go#L821-L823

https://github.com/pingcap/tidb/blob/6da55fc2b45996abccf76d7f68ddbceabc05455f/pkg/util/rowcodec/row.go#L36-L52

https://github.com/pingcap/tidb/blob/6da55fc2b45996abccf76d7f68ddbceabc05455f/pkg/util/rowcodec/row.go#L174-L188

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.