pingcap / pingcap/tidb

Planner: Interaction rule has never been used

Open
#61,282 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

The interaction rule was introduced on Oct 13, 2023 by commit https://github.com/pingcap/tidb/pull/47526 but was never actually used:

- The map `optInteractionRuleList` has always been empty since introduced.
- The condition check was incorrect to begin with. The author meant to check if the interaction rule is enabled but ended up doing the opposite via `isLogicalRuleDisabled(interactionRule)`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.