pingcap / pingcap/tidb

`pkg/ddl/util.PutKVToEtcd` is used in some non-DDL caller

Open
#61,156 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

It will print log with DDL label

https://github.com/pingcap/tidb/blob/7419112ef7bcd6fb0f0acb2e98222487e6616297/pkg/ddl/util/util.go#L366-L385

But there are some non-DDL caller like TTL / InfoSyncer. It's better to move it to a more common package.

Contributor guide

Open the contributing guide

Research direction

Start with pkg/ddl/util/util.go at the referenced lines and search for all callers of PutKVToEtcd, including the TTL and InfoSyncer paths mentioned in the issue. Identify an appropriate common package, move the utility there, update callers, and verify that the resulting logs no longer carry a DDL-specific label.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, databases
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.