pingcap / pingcap/tidb

`SUBTIME` should return `TIME` even if the argument looks like `DATETIME`

Open
#59,451 1 comment 0 reactions 0 assignees View on GitHub
component/expression severity/moderate sig/execution type/bug
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report

Please answer these questions before submitting your issue. Thanks!

### 1. Minimal reproduce step (Required)

### 2. What did you expect to see? (Required)

```

mysql> SELECT SUBTIME('2024-03-01', '24:00:00');
+-----------------------------------+
| SUBTIME('2024-03-01', '24:00:00') |
+-----------------------------------+
| -23:39:36 |
+-----------------------------------+
1 row in set, 1 warning (0.01 sec)

mysql> SELECT SUBTIME('2024-02-29', '1 12:00:00');
+-------------------------------------+
| SUBTIME('2024-02-29', '1 12:00:00') |
+-------------------------------------+
| -35:39:36 |
+-------------------------------------+
1 row in set, 1 warning (0.01 sec)

mysql> SELECT SUBTIME('2024-02-29', '1 00:00:00');
+-------------------------------------+
| SUBTIME('2024-02-29', '1 00:00:00') |
+-------------------------------------+
| -23:39:36 |
+-------------------------------------+
1 row in set, 1 warning (0.00 sec)
```

### 3. What did you see instead (Required)

```

mysql> SELECT SUBTIME('2024-03-01', '24:00:00');
+-----------------------------------+
| SUBTIME('2024-03-01', '24:00:00') |
+-----------------------------------+
| 2024-02-29 00:00:00 |
+-----------------------------------+
1 row in set (0.00 sec)

mysql> SELECT SUBTIME('2024-02-29', '1 12:00:00');
+-------------------------------------+
| SUBTIME('2024-02-29', '1 12:00:00') |
+-------------------------------------+
| 2024-02-27 12:00:00 |
+-------------------------------------+
1 row in set (0.00 sec)

mysql> SELECT SUBTIME('2024-02-29', '1 00:00:00');
+-------------------------------------+
| SUBTIME('2024-02-29', '1 00:00:00') |
+-------------------------------------+
| 2024-02-28 00:00:00 |
+-------------------------------------+
1 row in set (0.00 sec)
```

### 4. What is your TiDB version? (Required)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.