pingcap / pingcap/tidb

Enhancement: Some MySQL commands are not in Prometheus metric labels

Open
#59,230 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

I'm now using TiDB Cloud v8.1.1, and I found there was `17` label `Command Per Second` section.

It seems due to [this](https://github.com/pingcap/tidb/blob/master/pkg/server/metrics/metrics.go#L47-L110) metric values are not all of [mysql.Command](https://github.com/pingcap/tidb/blob/master/pkg/parser/mysql/const.go#L109-L142), so I think it's better to add all of them to prevent misunderstandings

Image

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.