pingcap / pingcap/tidb

Restore Parameter --tikv-max-restore-concurrency Should Be Limited

Open
#57,962 1 comment 0 reactions 0 assignees View on GitHub
component/br type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

When running BR restore operations, the `--tikv-max-restore-concurrency` parameter defaults to a very large value if tikv increase the config of `import.num-threads`. This can lead to an excessive number of requests being sent to PD,

The original assumption that this parameter is based on the default import.num-threads no longer holds when changes are made, leading to potential performance degradation and instability.

Expected Behavior

The restore operation should work efficiently without overwhelming PD, even when import.num-threads is increased. The default value of `--tikv-max-restore-concurrency` should consider the total number of TiKV nodes, make sure the total request pool in a limited size.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.