pingcap / pingcap/tidb

Occasional performance regression on benchmarksql

Open
#56,617 4 comments 0 reactions 0 assignees View on GitHub
affects-8.4 affects-8.5 may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 severity/major type/bug
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report
![image](https://github.com/user-attachments/assets/f6db47ae-8f4c-4e44-88d7-521db528ab45)
There is occasional performance regression on benchmarksql.
releated issue: #55426

### 1. Minimal reproduce step (Required)

1. Deploy a cluster with 3 TiDB and 3 Tikv.
2. Run benchmark benchmarksql (benchmarksql-1k) multiple times until find the specific io or cpu usage pattern on grafana.

### 2. What did you expect to see? (Required)
No performance regression.
QPS: 64039 (+6.4% compared to baseline 60193)
![image](https://github.com/user-attachments/assets/20470237-4744-4eb6-b920-f3aa50d0956a)
or
QPS: 61259 (+1.77% compared to baseline 60193)
![image](https://github.com/user-attachments/assets/8b134802-5c98-4121-b25e-0228a5bf9958)

### 3. What did you see instead (Required)
Performance regression .
QPS: 55187 (-8.3% compared to baseline 60193)
![image](https://github.com/user-attachments/assets/8cfaa5c0-5081-46a4-aecc-e2098ea5e99e)
or
QPS: 54639 (-9.20% compared to baseline 60193)
![image](https://github.com/user-attachments/assets/d998278c-53df-476d-8448-84ee9b941c07)

### 4. What is your TiDB version? (Required)

pingcap/tidb@26443dab89ba5b1a866de3c3e44e2f51468bc435
tikv/tikv@7c612787d0bfc57a339907ebcb26777dc296fd5f
tikv/pd@098b802fcda75b5ae0527b0b50b95ba8b31403cf
or
pingcap/tidb@74034d4ac243b3c14dbf5f8a9edb92e740da4212
tikv/tikv@de06b38a118582ee01d16ab4d3582bd8fa5cb635
tikv/pd@76bc34aee22554353bd7ea9785d3772dcb7ab31b

Contributor guide

Open the contributing guide

Research direction

Start by reviewing related issue #55426 and reproducing benchmarksql-1k repeatedly on the specified 3-TiDB/3-TiKV cluster. Compare the Grafana CPU or IO patterns and QPS across runs and the listed TiDB, TiKV, and PD revisions; done means the cause of the regression is identified and the benchmark no longer shows the reported drop.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, grafana, sql
Domain
databases, distributed-systems, observability, performance
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.