pingcap / pingcap/tidb

Support more locales for FORMAT()

Open
#56,167 1 comment 0 reactions 1 assignee Claimed by @dveeden View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

The `FORMAT(x,d,locale)` function now only supports `en_US`. Would be good to extend the support for other locales.

https://github.com/pingcap/tidb/blob/c13eb90fcf0ef3d4fe0fdb32851458651f7bc0a2/pkg/expression/builtin_string.go#L3366-L3386

It looks like this might allow us to remove:
- `mysql.GetLocaleFormatFunction`
- `mysql.formatENUS`
- etc

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.