pingcap / pingcap/tidb

br: make clear semantic of ratelimit

Open
#55,976 0 comments 0 reactions 0 assignees View on GitHub
affects-8.5 component/br severity/major type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

Currently, scope of `--ratelimit` differs between full backup and full restore. For backup, its scope is for a single grpc request to TiKV, while for its scope is for the whole restore requests. That's why if `--ratelimit` is set for backup, client request concurrency will decreased to only 1, which usually hurts the throughput of backup.

We need to make consistent semantic for the `--ratelimit`, and let it control on command scope instead of on single grpc request or on tikv instance level.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.