pingcap / pingcap/tidb

PR#55306 may caused 8.1% performance regression in benchmarksql

Open
#55,426 7 comments 0 reactions 1 assignee Claimed by @niubell View on GitHub
affects-7.1 affects-7.5 affects-8.1 affects-8.3 affects-8.5 component/pd severity/major type/performance type/regression
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report

### 1. Minimal reproduce step (Required)

1. Deploy a cluster with 3 TiDB and 3 Tikv.
2. Run benchmark benchmarksql (benchmarksql-1k).

### 2. What did you expect to see? (Required)

No performance regression.

### 3. What did you see instead (Required)

#55306 caused QPS regression 8.13% in benchmark benchmarksql (benchmarksql-1k) compared to baseline 60193.12.

| description | tidb | tikv | pd | QPS |
| ----------------- | ------------------------------------------------------- | ---------------------------------------------------- | ------------------------------------------------ | ------------------------------------ |
| last success | pingcap/tidb@29d52a7bff1d870f7001279a05797521ce23f2f2 | tikv/tikv@0e3806935c11be6bf9a75d8666a183520d3c4556 | tikv/pd@f3602e31640a55b61a3b14fb3989c4a0742a2416 | 61176.30 |
| first regression | pingcap/tidb@9a7e5cc2f7c433ce238a69a933251a565e089925 | tikv/tikv@0e3806935c11be6bf9a75d8666a183520d3c4556 | tikv/pd@f3602e31640a55b61a3b14fb3989c4a0742a2416 | 55297.83 |

### 4. What is your TiDB version? (Required)

pingcap/tidb@9a7e5cc2f7c433ce238a69a933251a565e089925

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.