pingcap / pingcap/tidb

The `connection count` metrics in TiDB after v7.5 should add `resouce_group` in legendFormat

Open
#55,422 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement
Currently, the `connection count` metrics use `instance` as the legend format:
https://github.com/pingcap/tidb/blob/1b172b674fa37259fabc4fcbc205274d4091fcce/pkg/metrics/grafana/tidb.json#L2917-L2925

However, after TiDB support `resource_group`, the same instance can have multiple `resource_group`, if legend format does not include `resource_group`, the metrics showed to user will looks like "Not deduplicated"

![20240815-104722](https://github.com/user-attachments/assets/68fa6f18-8204-4297-a02a-7774688c1e17)
![20240815-104735](https://github.com/user-attachments/assets/e05a2a15-ee96-4ae1-89aa-eae0c6546f5f)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.