Slow log query's parse concurrency is not stable
Open
type/enhancement
- Dominant language
- Go
- Stars
- 40.5k
- Forks
- 6.2k
- PR merge metrics
- PR metrics pending
Description
## Enhancement
There are two types of concurency for parsing slow query log, decided by whether Desc attribute is true:
https://github.com/pingcap/tidb/blob/d8098b970893c850cc318727d9dc336d0a677f35/pkg/executor/slow_query.go#L451-L455
- When Desc is true, the concurrency will be DistSQLScanConcurrency
- When false, the concurrency will be 1, due to the parsed log's first dimension length is always <= 1:
https://github.com/pingcap/tidb/blob/d8098b970893c850cc318727d9dc336d0a677f35/pkg/executor/slow_query.go#L316
https://github.com/pingcap/tidb/blob/d8098b970893c850cc318727d9dc336d0a677f35/pkg/executor/slow_query.go#L348
Contributor guide
Assessment
This issue has not been assessed yet.