pingcap / pingcap/tidb

Using `(*mock.Context).GetDistSQLCtx()` will make the benchmark slower

Open
#52,371 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

This issue only affects the benchmark, and it doesn't affect the performance of real `tidb-server`. I'd like to fix it to make the performance of benchmark aligned with the real tidb server.

The real session cache the `distsqlctx`. We should also cache the `distsqlctx` in the `mockResponse`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.