pingcap / pingcap/tidb

dynamic timeout for DrainClients for tidb graceful shutdown

Open
#50,143 0 comments 0 reactions 0 assignees View on GitHub
type/feature-request
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Feature Request

make the `gracefulCloseConnectionsTimeout` to be configurable

https://github.com/pingcap/tidb/blob/master/cmd/tidb-server/main.go#L934

**Is your feature request related to a problem? Please describe:**

The timeout for killing conns are capped at 15s when tidb gets SIGTERM. Would like this to be configurable so that we can adjust for various scecarios.

**Describe the feature you'd like:**

the timeout of DrainClients can be dynamically loaded whenever tidb is restarted.

**Describe alternatives you've considered:**

NA

**Teachability, Documentation, Adoption, Migration Strategy:**

NA

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.