performance of UnmarshalJSON can be improved
Open
component/json
sig/sql-infra
type/enhancement
- Dominant language
- Go
- Stars
- 40.5k
- Forks
- 6.2k
- PR merge metrics
- PR metrics pending
Description
## Enhancement
[cpu_tidb_infra-tidb-sql-shopping-catalog-prod-0a019c93.ec2.pin220.com_4000_3049994070.proto.zip](https://github.com/pingcap/tidb/files/12579512/cpu_tidb_infra-tidb-sql-shopping-catalog-prod-0a019c93.ec2.pin220.com_4000_3049994070.proto.zip)
UnmarshalJSON is CPU-consuming and can be improved:
```
golang encoding/json
BenchmarkUnmarshalJSON-8 122 9183362 ns/op
github.com/valyala/fastjson
BenchmarkUnmarshalJSON-8 466 2988689 ns/op
```
But appendBinaryJSON needs to been refactored to accept the input parsed by fastjson.
Contributor guide
Assessment
This issue has not been assessed yet.