pingcap / pingcap/tidb

`ConvertAndGetBinCollation` should return `utf8mb4_0900_bin` for `utf8mb4_0900_ai_ci`

Open
#46,360 0 comments 0 reactions 1 assignee Claimed by @YangKeao View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

The function `ConvertAndGetBinCollation` returns `utf8mb4_bin` for `utf8mb4_0900_ai_ci`. Now the `utf8mb4_0900_bin` has been added, it should return `utf8mb4_0900_bin` now.

But actually the implementation of `utf8mb4_0900_bin` and `utf8mb4_bin` is the same for `ILIKE`, so it doesn't affect any behavior, and I don't consider it as a bug.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.