pingcap / pingcap/tidb

Support `keepOrder = true` for partition table in BatchPointGetExec

Open
#45,702 0 comments 0 reactions 2 assignees Claimed by @Defined2014 View on GitHub
component/tablepartition type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement
To support keepOrder, we should support sort handles from different partition in `func (e *BatchPointGetExec) initialize(ctx context.Context)`, like

https://github.com/pingcap/tidb/blob/0e068edd6d6d95a663d225f964a335980ed0b39f/executor/batch_point_get.go#L256-L263
and
https://github.com/pingcap/tidb/blob/0e068edd6d6d95a663d225f964a335980ed0b39f/executor/batch_point_get.go#L353

After support it, we could remove the codes below and update test cases.

https://github.com/pingcap/tidb/blob/0e068edd6d6d95a663d225f964a335980ed0b39f/planner/core/find_best_task.go#L2551-L2554

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.