pingcap / pingcap/tidb

Some read requests do not honor the store labels

Open
#45,693 2 comments 0 reactions 0 assignees View on GitHub
affects-6.5 affects-7.1 affects-7.5 affects-8.1 affects-8.5 severity/major sig/transaction type/bug
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report

TiDB only set `MatchStoreLabels` on `executorBuilder.getSnapshot`, however some of executors may use `txn.{Get,BatchGet}` directly. These reads do not honor the store labels thus may access replicas on the slow tikv.

### 1. Minimal reproduce step (Required)

Deploy a cluster with 3 AZs and evict-slow-store-scheduler, run a stale read workload, and then slowdown a tikv in one AZ.

### 2. What did you expect to see? (Required)

The other two AZs should not be affected after leaders have been evicted.

### 3. What did you see instead (Required)

All AZs had perf regression during the fault injection.

### 4. What is your TiDB version? (Required)

release-6.5

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.